Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(markdown-pdf): crash with empty headings #293

Merged
merged 1 commit into from
Aug 19, 2020
Merged

fix(markdown-pdf): crash with empty headings #293

merged 1 commit into from
Aug 19, 2020

Conversation

dselman
Copy link
Sponsor Contributor

@dselman dselman commented Aug 19, 2020

Signed-off-by: Dan Selman danscode@selman.org

Changes

  • Protect the PDF transform from CiceroMark document that contain headings without text

@dselman
fix(markdown-pdf): crash with empty headings
3492acf 
Signed-off-by: Dan Selman <danscode@selman.org>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 91.746% when pulling 3492acf on ds-pdf-empty-heading into 6d0f440 on master.

DianaLease
DianaLease approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! If I understand correctly, if a heading is empty, tocItem will be false and it will not show up in the table of contents if there is one, correct?

@dselman
Copy link
Sponsor Contributor Author

dselman commented Aug 19, 2020

Correct.

@dselman dselman merged commit d3c6eec into master Aug 19, 2020
@dselman dselman deleted the ds-pdf-empty-heading branch August 19, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DianaLease DianaLease DianaLease approved these changes

@jeromesimeon jeromesimeon Awaiting requested review from jeromesimeon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dselman @coveralls @DianaLease